fix: terminal spacing, subflow disabled in preview#3055
Merged
emir-karabeg merged 2 commits intostagingfrom Jan 28, 2026
Merged
fix: terminal spacing, subflow disabled in preview#3055emir-karabeg merged 2 commits intostagingfrom
emir-karabeg merged 2 commits intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile OverviewGreptile SummaryFixed terminal spacing between executions and added disabled state visualization for subflows in preview mode. Changes:
Issues found:
Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant PW as PreviewWorkflow
participant SF as PreviewSubflow
participant UI as User Interface
Note over PW: Processing workflow blocks
PW->>PW: Check block.enabled ?? true
PW->>SF: Pass enabled prop to subflow data
Note over SF: Rendering subflow component
SF->>SF: Destructure enabled (default: true)
alt Subflow is disabled
SF->>UI: Show gray icon background
SF->>UI: Show muted text color
SF->>UI: Display "disabled" badge
else Subflow is enabled
SF->>UI: Show colored icon (blue/yellow)
SF->>UI: Show normal text color
SF->>UI: No badge displayed
end
Note over UI: Terminal spacing changes
UI->>UI: Render separator with mb-[6px]
UI->>UI: Render entry tree with pb-[6px]
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| <div | ||
| className='flex h-[24px] w-[24px] flex-shrink-0 items-center justify-center rounded-[6px]' | ||
| style={{ backgroundColor: blockIconBg }} | ||
| style={{ backgroundColor: enabled ? blockIconBg : 'gray' }} |
Contributor
There was a problem hiding this comment.
hardcoded 'gray' violates styling rules - use CSS variable like var(--surface-4) or #808080
Suggested change
| style={{ backgroundColor: enabled ? blockIconBg : 'gray' }} | |
| style={{ backgroundColor: enabled ? blockIconBg : 'var(--surface-4)' }} |
Context Used: Context from dashboard - Tailwind CSS and styling conventions (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/sim/app/workspace/[workspaceId]/w/components/preview/components/preview-workflow/components/subflow/subflow.tsx
Line: 99:99
Comment:
hardcoded `'gray'` violates styling rules - use CSS variable like `var(--surface-4)` or `#808080`
```suggestion
style={{ backgroundColor: enabled ? blockIconBg : 'var(--surface-4)' }}
```
**Context Used:** Context from `dashboard` - Tailwind CSS and styling conventions ([source](https://app.greptile.com/review/custom-context?memory=e1e9ca56-9819-463f-be67-0d2ba849ec4f))
<sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub>
How can I resolve this? If you propose a fix, please make it concise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
Solo.
Checklist